Ruben De Smet

Results 235 comments of Ruben De Smet

As far as I can tell, the decision is made to get into this branch: ```rust if number.national.starts_with(&code) && (!meta.descriptors().general().is_match(&number.national) || !validator::length(meta, &number, Type::Unknown).is_possible()) { number.country = country::Source::Number; number.national =...

Still the same case with the database present in #67, so that does not resolve this.

> Why is this still not merged? I was mostly waiting on a second pair of eyes from @gferon, actually.

> I could also make a PR for the DB from last week (8.13.34) + fixed warnings + bumped dependencies as I have a version with those changes. > >...

``` Parsing phonenumber v0.3.3+8.13.9 (current) Parsing phonenumber v0.3.3+8.13.9 (baseline, cached) Removing stale cached baseline rustdoc for phonenumber Parsing phonenumber v0.3.3+8.13.9 (baseline) Checking phonenumber v0.3.3+8.13.9 -> v0.3.3+8.13.9 (no change) Completed [...

`DEFAULT` is exposed as a `lazy_static!` in currently released versions, and putting it behind `Lazy` technically breaks the type. Since #63 is upcoming too, I think those efforts should probably...

> @rubdos I guess you should add a merge commit from the `main` branch? I should rebase indeed. But since this breaks the API/semver, we'll do that after we release...

@gferon, this too was 0.4-material because it breaks public API. I'll foresee a 0.3 branch for whatever I still want backported.

Sounds like a duplicate of #68 to me, no?