Ruben De Smet
Ruben De Smet
@gferon any chance you could have a look at this some time soon? Otherwise I might take this up.
> would expect you to be able to [[patch]](https://doc.rust-lang.org/cargo/reference/overriding-dependencies.html#the-patch-section) around this situation I think the `[patch]` section does not allow disambiguating which `zkgroup` reference to patch, although in my case...
Another effect: ``` error: failed to resolve patches for `https://github.com/signalapp/libsignal/` Caused by: patch for `zkgroup` in `https://github.com/signalapp/libsignal/` points to the same source, but patches must point to different sources ```...
> Definitely not ideal. As a workaround, though, you could `patch` _your own_ dependencies the same way, though, correct? Yes, correct indeed, that's what I went with for now: ```toml...
> Marking this as acknowledged but we haven't yet come up with anything better. thank you, much appreciated.
@bheylin In order to coordinate the effort a bit: I will make the separate issues asap (hopefully before noon CET), but I wonder which ones you intend to tackle yourself....
That sounds like a good path to follow. Keep the PR's small and concise, commit often, and ask feedback early! That way we'll reach a consensus with the least friction...
At first, I would avoid breaking the API. *Maybe* we can decorate some things with `#[deprecated]` at some point, but even that I would do in a follow-up version I'd...
> cannot be serialized. I thought the whole point here was to get rid of the (de)serialization step? Deseralization does also not necessarily imply that the binary representation can be...