Ryan Phillips

Results 77 comments of Ryan Phillips

Functions are usually pointers... It would be nice to have some benchmarks of the various scenarios to figure out the benefits.

This is because the event loop is still active by the server socket. Moving the server:close() before the asserts should fix it.

you might need gnu-make on OSX from your favorite package manager (homebrew, etc)

These two documents might turn out to be closely related... if it feels like we are duplicating, then let's combine them into one wiki page.

yes. looks like these should both be `done`

This pr looks ready! Nice job everyone. /lgtm

/triage accepted /priority important-soon /lgtm

Looks like all comments are resolved. Nice job! /lgtm