Kevin Ross

Results 141 comments of Kevin Ross

Trying to get this rebased, but error stack trace line numbers no longer line up...so it's a bit of a pain.

@thejameskyle this is rebased and good to go.

In general it appears this plugin, like others, has no awareness of flow's built-in libdefs or locally installed libdefs (e.g. flow-typed). @thejameskyle is there a plan for this?

Yes, #1811 is actually about `react-i18next`, with that code move to this PR. The re-definition of `TFunction` should be removed there.

@pedrodurek is already on it for react-i18next https://github.com/i18next/react-i18next/pull/1501 I checked next-i18next and it does not need any changes.

I think this is possible with vite and named exports + dynamic imports. This should be chunkable/tree shakeable. Another option with vite would be to investigate how they are handling...

Very nice! Once the new TS is released, we can accept a PR for this. We may need to think about modifying our usage tests so that we can properly...

FWIW - I substituted the root types into the 4.1 types file and my local build succeeded. I know that is anecdotal, but I think it is safe to say...

Wow, I just realized I filed this in the wrong repo - this should be filed in react-i18next, not here, but it is the same cast of characters, my apologies...