Kevin Ross

Results 141 comments of Kevin Ross

Correct. We also need to crawl/parse *.js.flow files from node_modules, these are untranspiled source files.

Just a quick note, I can see that https://github.com/thejameskyle/babel-plugin-react-flow-props-to-prop-types/blob/master/fixtures/imports/code.js is importing types from other files. This does not cover libdefs, but it is cross-module. Source seems to be [`_convertImportSpecifier`](https://github.com/thejameskyle/babel-plugin-react-flow-props-to-prop-types/blob/master/src/convertTypeToPropTypes.js#L411). The...

I've determined that importing from a libdef might be too ambitious near term, but importing cross-module from js source code seems plausible based on the code I found above. I...

@UchihaVeha - that is the exact case for this issue, it does not import the type from another file so it is null and fails. If type `TodoView` were in...

BTW, `weak` mode still works, but the built-in react libdef requires the type parameters, so it is a little stricter than before.

This can be worked around with `extends React.Component`, so is this just new information or do we need to change anything in the plugin?

I think that is a good idea. It's not foolproof but it's going to work for the majority.

It seems like we are missing a declaration or require for Here is the entire build file for that: ```js "use strict"; /** * return type of ReactDOM.findDOMNode() * *...

Compared to when we encounter `import type { Element } from 'react'`, which generates: ```js var babelPluginFlowReactPropTypes_proptype_Element = require('react').babelPluginFlowReactPropTypes_proptype_Element || require('prop-types').any; ``` It seems like this plugin isn't recognizing global...