Rob Spoor

Results 17 comments of Rob Spoor

I've already committed the tarbal contents for 0.1.46 to 0.1.54, and created a pull request for that.

I have tried to add documentation for IdentityRepository, but it's not clear enough what it's actually for. I've only seen it in action once, with Pageant, but that was mostly...

You'll need to register the JavaTimeModule (see https://github.com/FasterXML/jackson-modules-java8).

`ObjectMapper` instances don't register modules that are available on the class path automatically. There is a method though, [findAndRegisterModules()](https://fasterxml.github.io/jackson-databind/javadoc/2.7/com/fasterxml/jackson/databind/ObjectMapper.html#findAndRegisterModules()).

Aren't you simply missing a dependency? `JavaTimeModule` isn't in the default databind dependency, but instead this one: https://mvnrepository.com/artifact/com.fasterxml.jackson.datatype/jackson-datatype-jsr310

Sorry, I thought you were a Pioneer developer. I'm not either, I am just someone who's interested. I was trying to work on a pull request, but I added a...

I could recreate it with a POJO. Adding the `.findAndRegisterModules()` then fixes the test. If I then remove the JSR310 dependency the test fails again. I'll create a pull request...

See #629. Note that I made it the responsibility of the Pioneer consumer to provide the Jackson JSR310 module; I've only added it as a test dependency.

For #629 I have some uncommitted changes that register a `Jdk8Module` and a `JavaTimeModule` if these are available, and a `KotlinModule` if it's available and so is Kotlin (check on...

I get the idea of not exporting `org.junit.platform.commons.util`. The package is meant for use by the JUnit framework itself. The only thing is, it's full with utility classes and methods...