Robert Bradshaw comments

Results 76 comments of


                                            Robert Bradshaw

trafficstars

Initial prototype of using Beam transforms directly in a Flink pipeline.

R: @kennknowles

Initial prototype of using Beam transforms directly in a Flink pipeline.

(Looks like I'm going to have to rebase this on the org.apache.beam.runners.core.construction move...)

Initial prototype of using Beam transforms directly in a Flink pipeline.

> (Looks like I'm going to have to rebase this on the org.apache.beam.runners.core.construction move...) Done. PTAL.

Initial prototype of using Beam transforms directly in a Flink pipeline.

Ping.

Initial prototype of using Beam transforms directly in a Flink pipeline.

I've addressed all your comments so I'm going to go on your LGTM and merge this.

Initial prototype of using Beam transforms directly in a Flink pipeline.

Most of these are because Map.get() uses nulls rather than exceptions to indicate keys aren't there (that tautologically should be). Cleaned up at https://github.com/apache/beam/pull/30488

Remove unneeded View.asList when View.asIterable suffices.

Run Java PreCommit

Remove unneeded View.asList when View.asIterable suffices.

I just confirmed via experimentation that this is not update compatible :(. Still thinking about the best way forward here.

Remove unneeded View.asList when View.asIterable suffices.

I am planning on guarding this change with the new option. On Sat, Dec 9, 2023 at 4:39 AM github-actions[bot] ***@***.***> wrote: > > This pull request has been marked...

Generalize file based source output capabilities

This sounds like a good change. Formally adding R: @damondouglas for follow-up.