beam
beam copied to clipboard
Initial prototype of using Beam transforms directly in a Flink pipeline.
Handling DataStream, windowing, and more complex types will come in a future PR.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead. - [ ] Update
CHANGES.mdwith noteworthy changes. - [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.
See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.
R: @kennknowles
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
(Looks like I'm going to have to rebase this on the org.apache.beam.runners.core.construction move...)
(Looks like I'm going to have to rebase this on the org.apache.beam.runners.core.construction move...)
Done. PTAL.
Ping.
Otherwise LGTM as far as getting this going. Very cool!
I've addressed all your comments so I'm going to go on your LGTM and merge this.
There are still lots of nullness checks suppressed that presumably should be fixed, not suppressed. I didn't see any systemic reason to disable checking.
Most of these are because Map.get() uses nulls rather than exceptions to indicate keys aren't there (that tautologically should be). Cleaned up at https://github.com/apache/beam/pull/30488