beam icon indicating copy to clipboard operation
beam copied to clipboard

Initial prototype of using Beam transforms directly in a Flink pipeline.

Open robertwb opened this issue 1 year ago • 4 comments

Handling DataStream, windowing, and more complex types will come in a future PR.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • [ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • [ ] Update CHANGES.md with noteworthy changes.
  • [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels Python tests Java tests Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

robertwb avatar Feb 15 '24 20:02 robertwb

R: @kennknowles

robertwb avatar Feb 15 '24 20:02 robertwb

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

github-actions[bot] avatar Feb 15 '24 20:02 github-actions[bot]

(Looks like I'm going to have to rebase this on the org.apache.beam.runners.core.construction move...)

robertwb avatar Feb 15 '24 21:02 robertwb

(Looks like I'm going to have to rebase this on the org.apache.beam.runners.core.construction move...)

Done. PTAL.

robertwb avatar Feb 15 '24 21:02 robertwb

Ping.

robertwb avatar Feb 26 '24 17:02 robertwb

Otherwise LGTM as far as getting this going. Very cool!

kennknowles avatar Feb 26 '24 18:02 kennknowles

I've addressed all your comments so I'm going to go on your LGTM and merge this.

robertwb avatar Mar 04 '24 18:03 robertwb

There are still lots of nullness checks suppressed that presumably should be fixed, not suppressed. I didn't see any systemic reason to disable checking.

kennknowles avatar Mar 04 '24 19:03 kennknowles

Most of these are because Map.get() uses nulls rather than exceptions to indicate keys aren't there (that tautologically should be). Cleaned up at https://github.com/apache/beam/pull/30488

robertwb avatar Mar 04 '24 20:03 robertwb