rgret-dev

Results 14 comments of rgret-dev

I can understand the concerns (because who wants their project to break?) but personally think it's the wrong approach for this library. Eventually there will be a point where the...

FYI, it looks like `once_cell` is going to be added to the standard library in the near future. See https://github.com/rust-lang/rust/pull/105587

That URL and many HTTPS sites work just fine for me. What happens if you try fetching with curl via command line? Any errors? ```shell curl https://github.com/LadybirdBrowser/ladybird ```

Hmm, yeah that would probably cause issues if it can't download the cert file 😅 If it fails to establish a TLS connection at build time, that might indicate a...

I think this is problematic since it relies on checking out a specific commit which isn't there when cloning with `--depth=1` https://github.com/LadybirdBrowser/ladybird/blob/420949b1349451fdfb004e06625b9efefae24d19/Toolchain/BuildVcpkg.py#L35

This doesn't seem correct because if I try to enter a hostname that is setup in my hosts file (e.g. `http://testing`) then it redirects to a search engine. I agree...

Your new changes don't fix single-word inputs. Additionally, you'll want to rewrite your git history (i.e. a single commit per fix/feature) before pushing and make sure the messages are in...

I'm also on Linux Mint 21.3 and did the following after following the normal build instructions: Install the newest C++ standard library: `sudo apt install libstdc++-12-dev` Install clang-18: (taken from...

Is there any reason we still MUST the `wait_for_termination()` call? My PR (#2553) partially addresses this by just warning when that fails instead of crashing.

You can view the build instructions/requirements here: [BuildInstructionsLadybird.md](https://github.com/LadybirdBrowser/ladybird/blob/001df2493568cb01eb6d8b47a888be811896607a/Documentation/BuildInstructionsLadybird.md) > Qt6 development packages, nasm, additional build tools, and a C++23 capable compiler like g++-13 or clang-17 are required. > CMake 3.25...