Tim Ruffing comments

Results 744 comments of


                                            Tim Ruffing

msan: notate more variable assignments from assembly code

For posterity, the reason why clang 15 was happy with just the annotation in https://github.com/bitcoin-core/secp256k1/commit/31ba40494428dcbf2eb5eb6f2328eca91b0b0746 is this: The default of what is considered a "use" of uninitialized memory was changed...

use EXIT_ codes instead of magic numbers for exit(...) and main return values

Concept ACK I had the same thought in the past. [My suggestion to remove `assert()` in the examples](https://github.com/bitcoin-core/secp256k1/pull/1606#issuecomment-2363217373) is slightly related and could be addressed in another commit in the...

use EXIT_ codes instead of magic numbers for exit(...) and main return values

> The comment says "This will return 0 if the signature can't be parsed correctly" however the return value in case of failure is 1. Shall I just adjust it...

elements: add rangeproof nonce derivation

fixup looks good!

core/secp256k1_zkp: add blinding and rangeproof API

Changes look good to me. :+1:

Clear sensitive memory without getting optimized out (revival of #636)

@theStack Can you rebase this on top of musig which has introduced a few more code locations that need clearing? Personally, I'd love to have this in the next release.

Clear sensitive memory without getting optimized out (revival of #636)

This one comes to my mind, too: https://github.com/bitcoin-core/secp256k1/blob/a88aa9350633c2d2472bace5c290aa291c7f12c9/src/util.h#L253-L254

Clear sensitive memory without getting optimized out (revival of #636)

> Taking care of those could be probably go into an own PR, as its trivial to fix and review and hence has a significantly higher chance to land in...

Clear sensitive memory without getting optimized out (revival of #636)

> OTOH, "ctime-tests should run with the same binary as in the release" then doesn't hold anymore. I don't think so. If we wrap the new _CHECKMEM_UNDEFINE **within _memclear** in...

`src/scalar_4x64_impl.h:361:5: error: ‘asm’ operand has impossible constraints`

I'm unable to reproduce this on my gcc 14.2.1. Can you provide some more context, please? - What does `native` resolve to? Can you provide a reproduction command with the...