Rafael Schouten

Results 1265 comments of Rafael Schouten

DD also defines `rebuild` methods for these to update the contents programatically, with `ConstructionBase.setproperties` as the default keyword constructor. Keeping field names the same removes all boilerplate. You can `rebuild`...

@nalimilan Multiplying values by 2 was a bad example... practically it's more like swapping out their contents, e.g. a `Vector`, for the individual values of the vector. But 2 fields...

Thanks for looking into this. DynamicGrids could allow passing in the FTFont directly, but a cache seems like a cleaner solution, and maybe better if we dont all implement that....

Yes depending on FontConfig.jl here does look like the best solution. Im happy to review a PR for this.

I think what was overlooked is that we can just accomodate both. If you pass `:untested` or maybe `:unproven` to `@implements` then we wont run tests in precompile, and you...

Totally. Although we have half the code complexity already (because it was never deleted). I think this will only be about 10-20 lines added. For the user experience I think...

I had the exact same thought when I read it the other day. I guess it should always test them all? Maybe the thinking was to cut down test time,...

Yes its possible in the testing, but you don't get any traits to check that you passed it. The idea is that both tests and traits would be inherited automatically.

@gdalle I just realised having inheritance for options means we have to define the `NamedTuple` of options inside the macro so we can get the keys to define abstract types...