Rafael Schouten

Results 1271 comments of Rafael Schouten

Hmm maybe that will just work? But its a weird nested object in terms of default types. I think adding a field is better.

Ah right that's kind of annoying but yes probably And pass the crs through

This generally looks good. But before we merge it I think we need a PR to GeoInterface.jl adding this specification to the docs, so it can be discussed as an...

Probably test in stack.jl ?

Yeah, we really need that kind of high level docs integration. The packages to do this well are pretty new, and docs are just a lot of work and we...

This all sounds good to me. But there are potential problems like: we add a `Colorbar` to some plots, set axis names manually, and add our own attributes to `Attributes`....

Are you saying we just need to add that method? I don't totally follow like what does "just works" mean exactly here

Ah should probably be AbstractDimMatrix? Maybe a typo

I think we need to define generic `readblock` on AbstractArray` for this to work generally, it broke a lot of things when I tried it locally.