Radhakrishna Tumbalam Gooty

Results 9 comments of Radhakrishna Tumbalam Gooty
trafficstars

@lbianchi-lbl It appears to me that the test failures are not because of this PR. Could you please confirm?

Sorry, @andrewlee94 ! Until an hour ago, tests were failing on 3.8 and 3.9 (it said, did not find idaes, or something like that). I don't know what changed, the...

@adam-a-a Yes, I made sure that the changes are backwards compatible. The changes I made to the existing code are (i) inherit `MultiPeriodModel` class from pyomo's `ConcreteModel`. This way, an...

Thanks @adam-a-a for reviewing the PR and for the suggestion! I changed all the methods to `multi_period` to keep it consistent and backwards compatible.

@adowling2 I can help @Xinhe-Chen with tests. Since this is needed for the DISPATCHES case studies, I changed the priority label from low to high.

Thank you @dguittet for reviewing the PR and for testing it with the nuclear case study! After this PR is merged, would you be able to open a PR in...

@lbianchi-lbl `scipy`'s clustering methods are not very robust. For example: ``` In [2]: import numpy as np In [3]: data = np.array([[0,0], [0,1], [1,1], [1, 0], [10, 0], [10, 1],...

Thank you @jsiirola for the feedback! I agree that either of the suggested alternatives makes the code cleaner. If I understand things correctly, the first alternative is fairly easy to...

@ksbeattie @adam-a-a It's okay if this PR does not make it to the final DISPATCHES release. @lbianchi-lbl We do not have a planned completion date yet. For now, let's not...