Winnie Kwon

Results 87 comments of Winnie Kwon

I think we are saying the same thing. Option 1 proposed is to call different flavors as CAPI does. CAPI can do it without flags because their tests accepts flavors...

## PoC While waiting for controller-tools and listMapKey issues to be worked on, did an *Initial PoC* with test purpose CRDs. This required some hacks so the result needs to...

I know the issue description says what you have implemented but considering CAPA will introduce v1beta2 in coming months, How about changing the API in v1beta2 and implement a conversion...

Hi @s1ntaxe770r, thanks for your interest in the issue. Very happy to hear that. You are on the correct path - providers usually create a file called conditions_consts.go to define...

Created two sub-issues. Let's continue the discussion for GCPMachine conditions in https://github.com/kubernetes-sigs/cluster-api-provider-gcp/issues/576

/remove-lifecycle stale

Copying from https://github.com/kubernetes-sigs/cluster-api-provider-gcp/issues/570#issuecomment-1090851633 > I noticed CAPA and CAPZ have a concept of "Reasons" example over [here](https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/eaafc000e33e37d16b1cd1b90795674f3fd8d521/api/v1beta1/conditions_consts.go#L123) , would this be necessary for GCP machines? Yes, `Reason` is a field...