cluster-api-provider-aws
cluster-api-provider-aws copied to clipboard
kubernetes-sigs
[WIP] feat: deprecate DisableVPCCNI in AWSManagedControlPlane
What type of PR is this? /kind deprecation
What this PR does / why we need it:
This PR deprecates the disableVPCCNI field on AWSManagedControlPlane in favour of vpcCni.disable.
Which issue(s) this PR fixes Fixes https://github.com/kubernetes-sigs/cluster-api-provider-aws/issues/3410
Special notes for your reviewer:
Checklist:
- [x] squashed commits
- [ ] includes documentation
- [ ] adds unit tests
- [ ] adds or updates e2e tests
@charlie-haley: This issue is currently awaiting triage.
If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members by writing /triage accepted in a comment.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Hi @charlie-haley. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign fabriziopandini after the PR has been reviewed.
You can assign the PR to them by writing /assign @fabriziopandini in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@charlie-haley: PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Hello 👋 :)
I don't see yet a warning for the deprecated field usage. But since this is a WIP I assume you'll just add that later? :D I'm referring to this comment from Richard:
report that DisableVPCCNI is deprecated
Cheers! :)
Hello wave :)
I don't see yet a warning for the deprecated field usage. But since this is a WIP I assume you'll just add that later? :D I'm referring to this comment from Richard:
report that DisableVPCCNI is deprecated
Cheers! :)
I've added a deprecation notice to the description field on disableVPCCNI, do we need it anywhere other than that?
I know the issue description says what you have implemented but considering CAPA will introduce v1beta2 in coming months,
How about changing the API in v1beta2 and implement a conversion webhook rather than deprecate a field, disableVPCCNI and introduce a new field, vpcCni.disable with extra logic in validation webhook? I think the former option is simpler for fields with exact same functionality.
Thoughts, @richardcase?
How about changing the API in v1beta2 and implement a conversion webhook rather than deprecate a field,
disableVPCCNI
As v1beta2 is imminent, I think we should go this route :+1:
@Ankitasw: Closed this PR.
In response to this:
/close in favor of #3846
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.