Patrick Williams
Patrick Williams
@jamietre There are definitely a number of issues with the caching as it currently exists. I'm not sure if this is why you're running into this issue, but using babel...
@xtuc Given that the cache was created by a process that had enough memory, I'd be sort of surprised if a cache was ever large enough to cause issues. My...
@jamietre I didn't mean to give the impression I had done a lot of work to profile it. I wouldn't be surprised if you could show significant improvements. I just...
@hzoo My job has given me the rest of the week to upgrade to babel7 and try to improve the caching for our use cases. Outside of just creating benchmarks...
@insin this should be ready now...any idea how many types of files you'd like to support?
:+1: ...and the promise library is phenomenal. not likely to disappear anytime soon
We just extended the RouteStore, overwrote the dehydrate function and stripped out the route. Has been working fine in production for weeks.
@xbIm ```es6 class extends RouteStore.withStaticRoutes(routes) { dehydrate() { const { currentNavigate: { route, ...currentNavigate }, ...dehydrated } = super.dehydrate(); return { ...dehydrated, currentNavigate }; } } ```
Didn't see this until after submitting a pr, so I don't know if it aligns with what @arasmussen wanted. https://github.com/chromakode/react-html-email/pull/21