Steve Purcell
Steve Purcell
I'd be generally in favour of this, because I'm not sure if any of the more active maintainers have any specific love for cmake, and it would be good to...
> Isn't this just replacing one big blob (well a shell script isn't technically a blob but this one is very big) with another? Compared to that a Makefile is...
> Personally I hope that the classical `make; make install` still works. Seems very reasonable!
Aha, this PR will – of course – need to wait until after the weekly regeneration of the ASF modules. Until then, linting will continue to fail because the existing...
Merging now, since the lint step passes.
Hi, I noticed that you've pushed more changes and requested several further reviews, but without having addressed the feedback I gave last time. Without this engagement, we would be unlikely...
I'm going to close this PR: the CLA was not signed, nor were there responses to the feedback and requests we shared above. There is every sign that this PR...
Hmm, it remains extremely hacky to be modifying the results returned by this function based on globals.
> Besides, I am not sure **vh** is the best unit to use: for very large screens it will result in smaller subtitles, I think **vw** could be better. Isn't...