Peter Sobolewski

Results 709 comments of Peter Sobolewski

@kephale thanks for the heads up. I think this PR is DoA, but graph layer might actually motivate this sort of thing more? Not sure the exact use cases.

I think the settings schema issue also falls under this: https://github.com/napari/napari/issues/5316 Particularly the behavior when updating napari in place -- downgrading will always be hard to handle. Upgrade in place...

I'm a bit confused, I don't get why this fix is in this repo and not the plugin? Here's what i observe: 1. the continued loading appears to be due...

BTW, i can reproduce the infinite spin without zarr/etc. so that's a napari bug -- maybe just a visual? dunno. Made an issue: https://github.com/napari/napari/issues/7070

Any thought to putting camera stuff in View? 👀

I so rechecked with fresh env install 0.4.19, set some keybinds, and then update to 0.5.0a from pypi. It messes up the keybindings -- everything that used Command key is...

Ok, what if can't figure out how to migrate keybinds properly, maybe we should add a migrator (even a no-op will update the schema version in the settings), but then...

I think the failed test is due to lack of migrator? I think what is happening is: - the settings file written at the start of the test doesn't have...

@jni I think it's this: https://github.com/napari/napari/pull/7053#issuecomment-2212027739 If you add a no-op migrator: ``` @migrator('0.5.0', '0.6.0') def v050_060(model: NapariSettings): """Migrate from v0.5.0 to v0.6.0 return ``` Then it should work.

On phone ATM but I will review before EOD.