Peter Sobolewski
Peter Sobolewski
Thanks for the issue! Certainly seems reasonable to me.
I think this issue on napari/npe2 is related/relevant: https://github.com/napari/npe2/issues/95
> It is not a bug, it is feature request. I mean, if it never worked, for any layer, then yes? But I think it's a very reasonable expectation that...
Flake8 said: ``` napari_ome_zarr/_reader.py:113:13: W503 line break before binary operator napari_ome_zarr/_reader.py:114:13: W503 line break before binary operator ``` So i switched it in https://github.com/ome/napari-ome-zarr/pull/126/commits/55bf4cafc745f6ac84a74faef3e46c050f219697 but then pre-commit switched it right...
@joshmoore yeah if you see my comment https://github.com/ome/napari-ome-zarr/pull/126#issuecomment-2848106295 precommit auto fixes it back to the fail state because of black and flake8 fighting -- i think. Maybe https://github.com/ome/napari-ome-zarr/pull/93 would help...
@joshmoore Unless I misunderstand it, the test in question doesn't do anything ome/zarr related? https://github.com/ome/napari-ome-zarr/blob/20853c235ba9e2fbb20e0632f5d96b72d5de4f56/napari_ome_zarr/_tests/test_reader.py#L106-L127 It looks to be testing napari functionality that when you add a multiscale layer and...
huh, the `unnamed` shouldn't be there for the case of known colormaps. I will take a quick look -- it's been a while, sorry!
I made a quick PR to nuke the multiscale test in it's own PR: https://github.com/ome/napari-ome-zarr/pull/132
OK, i see it. `ensure_colormap` always adds new colormaps to the dict and then I assign an existing colormap if it exists. Edit: because ome-zarr-py appears to always return `[[0,...
OK so looking at the flake8 W503 more: https://www.flake8rules.com/rules/W503.html It shouldn't be enabled, as it's not best practice. It should already be ignored by default... The reason is the `--ignore`...