Val Lorentz
Val Lorentz
@cottongin Do you want to do it?
But it would require a lot of requests to GitHub, probably enough to be banned before the search even ends.
Actually, `inFilter` should not modify a message. It should make a copy and return the copy instead. Can I close this issue?
Can I see your code?
I can't reproduce your issue. The following test passes: ```py def testHistoryInFilter(self): class Callback(irclib.IrcCallback): channels_set = None def name(self): return 'testcallback' def inFilter(self2, irc, msg): return ircmsgs.IrcMsg(prefix='prefix2', command='PRIVMSG', args=('#chan2', 'content2'))...
I don't know. What happens if you run it yourself?
@nyuszika7h Sorry for the late reply. You should put it in the PrivmsgTestCase class, in test_callbacks.py. (Most classes other than those in test_irclib would do, actually).
> Thus I have Aka "ops" for it (`aka add ops channel alert !ops $*`, but I am pointed out that this doesn't work in private. Yes, because it's missing...
I'd rather have a single parser that fetches both instead of parsing the document twice, but it's a reasonable way to do it, yeah. Feel free to send a PR...