P. L. Lim

Results 2109 comments of P. L. Lim

> Especially since other projects don't encounter these difficulties. That is a not a fair comparison. I doubt all projects are fully annotated.

Just focusing on renaming `quantity.py` to `_quantity.py` here: That is going to break everything that mentioned `astropy.units.quantity.somethingsomething` downstream. It is too scary to think of the consequences. Why don't we...

FWIW having a template is nice. Thanks!

Given the long standing issue * https://github.com/astropy/pyvo/issues/155 I will let @tomdonaldson review this one in case some of the Path changes are undesirable downstream.

I am still not convinced this is going to help in the effort of moving `samp` downstream. Should we just perpetually ignore this ruff rule for SAMP and close this...

> wouldn't that mean that this subpackage is essentially frozen until it's removed from the core library Pretty much the state it is in for a while now. Nothing new...

> so that's on me Not at all. It is not advertised anywhere. And I am sorry if this was a waste of time.

The decision to use v3 was intentional, see https://github.com/spacetelescope/jdaviz/pull/2855 But perhaps not needed anymore? 🤷‍♀️

Hard to tell whether this fix works or not given a seemingly unrelated error: `Error: Timed out waiting for: tcp:8866` I will defer to @rosteen Thank you!