P. L. Lim

Results 2078 comments of P. L. Lim

Needs: * change log * fix pre-commit check * identify a coordinates maintainer that is well-versed in Cython to review Thanks!

> Looks like macOS runners were just migrated to ARM64 We can skip those tests in OSX or downgrade that job to older mac x86 runners. But we can discuss...

Re: `benchmark` label -- I added it. When it completes, you will see a summary in the log and also option to download artifacts.

Hmm is this related or just VM being flaky? ``` | Change | Before [e9ba0dba] | After [9eb6abd7] | Ratio | Benchmark (Parameter) | |----------|----------------------|---------------------|---------|--------------------------------| | + | 44.1±0.1μs |...

Please use the new `perf` change log category, see: * https://github.com/astropy/astropy/pull/16694

Once you have moved the commenting on PR part to another workflow, I can revisit and try it out on my fork. In the meantime, it is up to OpenAstronomy...

Re: https://github.com/astropy/astropy/pull/16642#issuecomment-2200091300 Not sure about that. The README pointed to https://github.community/t/github-actions-are-severely-limited-on-prs/18179/4 that does not exist. 🧐 Can we be sure it is 100% secure?

That `app.js` might be okay now, but we cannot guarantee it. And if we pin by hash, we might miss future critical updates. If we do not, we have to...

This should only be done **after** (or **together with**) a PR to drop Python 3.6.

> So if anything in astropy relies on reversing `OrderedDict` Is there a way to check?