Radim Řehůřek

Results 318 comments of Radim Řehůřek
trafficstars

Check out [PEP 585](https://www.python.org/dev/peps/pep-0585/): starting with python3.7, annotations become infinitely more readable. May be worth the wait, until we drop py3.6?

To me – yes. I don't have anything against annotations but rarely use them, because I find they obfuscate more than clarify. Cons>pros. A nicer, better integrated annotation syntax could...

@petedannemann we have bad experience with free time-limited trial accounts, because when they expire it's chaos. Or worse, somebody forgets and we get billed for money. Unfortunately we have zero...

Thanks for the detailed quality report. Do you know how the version *without* `smart_open` fetches data from S3? Is it using `boto` or not?

You mean when reading them from S3? So the issue is specific to the Parquet format on S3?

Yes, that's what I meant. The issue appears only with smart_open and parquet, not with smart_open and csv (for example). That's a strong clue. We'll look into this, thanks for...

@kenahoo thanks for the clear and detailed report. I agree context managers should be closing handles, so that looks like a bug. @mpenkov is busy ATM – any chance you...

What is "default rate" and how did you check it's "much higher"?

20x slower is really weird. There should be very little overhead in `smart_open`, so the numbers ought to ± match. Btw `get_object().iter_lines()` didn't exist back then, maybe it's worth changing...

I never used that functionality, so no preference either way. Clean and consistent is my general preference – or we'll drown in corner cases.