smart_open icon indicating copy to clipboard operation
smart_open copied to clipboard

Drop support for host/port in S3 URLs

Open mpenkov opened this issue 6 years ago • 1 comments
trafficstars

What about dropping support for host/port in S3 URLs (endpoint_url may be still provided in transport_params)? It seems this is rarely used feature and these URLs also break RFC rules (like two @ characters in url). Parsing will be much easier without that (parse.urlsplit will be enough).

Originally posted by @mrk-its in https://github.com/RaRe-Technologies/smart_open/issues/378#issuecomment-551143613

@piskvorky what do you think?

mpenkov avatar Nov 09 '19 02:11 mpenkov

I never used that functionality, so no preference either way. Clean and consistent is my general preference – or we'll drown in corner cases.

piskvorky avatar Nov 09 '19 08:11 piskvorky