Piotr Olaszewski

Results 85 comments of Piotr Olaszewski

I invited a @seanbright as an owner. Maybe with a couple of members, I'll also try to come back to actively supporting this project. > I'm also open to the...

I think we need to support `ConnectionDetails`, as it helps with application development. PR #69, created by @eddumelendez, addresses this. We should prioritize resolving this issue. Ref: * https://github.com/openfga/spring-boot-starter/issues/58

Many thanks for this contribution. Could you elaborate on the reason for this change? I'm not sure why we need to do this 🤔

What I don't like about this code is the fact that we have to refer to the `Version` object for the values every time, instead of doing it once during...

I’ve decided not to merge this, as I don’t see a clear benefit. If you have strong arguments in favor, feel free to reopen the PR.

This PR LGTM :heart: I'm just curious if naming the project `spring-boot-starter` is the best choice, considering it will include Testcontainers and Docker modules. Just sharing my thoughts :thinking:, not...

> Can you share a project that reproduces the issue, please? @eddumelendez yes! Sure, I even saw you tweet about it recently :wink: Here is a minimal repro: https://github.com/piotrooo/spring-boot-restart-scope You...

It seems to be a deadlock here: https://github.com/spring-projects/spring-authorization-server/blob/ce76f5c23d3e298b8e929a069bcd7470dfcb6d10/oauth2-authorization-server/src/main/java/org/springframework/security/oauth2/server/authorization/JdbcOAuth2AuthorizationService.java#L460-L462 When someone has the max pool size set to 2, and there are 3 requests, there are no available connections because the...

@jgrandja Just a gentle ping about this. It's occurring in our production environment and seems like a serious problem (at least to me). I can provide a PR with the...

@jgrandja, thanks for the response :pray: > If the RegisteredClient does not exist for the retrieved OAuth2Authorization then the data is in an invalid state as the RegisteredClient MUST exist...