spring-boot-starter icon indicating copy to clipboard operation
spring-boot-starter copied to clipboard

Published 20 hours ago • verified publisher icon openfga

chore: move src folder to subproject

Open eddumelendez opened this issue 1 year ago • 4 comments

It also supports ConnectionDetails for upcoming Testcontainers and Docker Compose service connection support.

eddumelendez avatar Oct 02 '24 15:10 eddumelendez

Thank you for this contribution! Our apologies for the delay in reviewing your PR. As maintainers, we are working hard to cover as much as we can, and the assistance of the community is always deeply appreciated!

While the code looks sound, I would also advise updating the README.md file to note the new structure. You can find this referenced in the OpenFGA Contribution Guidelines.

Others may have some questions to confirm that the build process works end-to-end locally with the new subproject structure, given the upcoming Testcontainers and Docker Compose service connection support. But my main comment is the request for a PR for documentation updates and linking that PR to this one in this PR's description.

hello-caleb avatar Dec 03 '24 14:12 hello-caleb

Thanks @eddumelendez! Also apologies for the extended delay here 😞.

I love this change, and its a structure I had originally envisioned, but I wonder if it will run into the same issue with nexus publishing that we encountered before? We originally envisioned a structure similar to what you have done here, but had issues with nexus publishing that didn't appear to have a nice solution (though it has been some time since then and I see the issue has many comments).

jimmyjames avatar Dec 11 '24 17:12 jimmyjames

This PR LGTM :heart:

I'm just curious if naming the project spring-boot-starter is the best choice, considering it will include Testcontainers and Docker modules. Just sharing my thoughts :thinking:, not saying it's wrong.

Maybe just spring-boot would be enough.

piotrooo avatar Dec 12 '24 08:12 piotrooo

@eddumelendez - thanks for this PR! We're not ignoring it, we'd just like to test it with the release process taking into account what @jimmyjames has mentioned above. Do expect this to take some time as we have a few other priorities, but we'll be investigating once we're back from the holidays, so expect an approval or a clearer feedback in the first few weeks of 2025

rhamzeh avatar Dec 16 '24 17:12 rhamzeh