Philipp Schuster

Results 200 comments of Philipp Schuster

*Short notice: I'm currently on vacation and probably won't work on the PRs until the last week of August*

Any update, @DanielKeep ?

@nicholasbishop @GabrielMajeri I finally had time working on this. It is still not ready to merge but much closer now. I add it as a new workspace member `uefi-fs`. Let...

> * Will a `PathBuf` API be provided as well? Wouldn't necessarily need to be in the initial PR. So far, the API a user sees is just a `&str`....

@nicholasbishop I think this is ready for review and merging, when we keep the following things in mind: - So far, the public API change and exports are very small...

> I'm in favor of merging this once the tests are passing and the one `todo!()` is fixed. We can handle cleanups/additional tests in follow up PRs. I've created a...

> ``` > "-C", "link-args=/debug:dwarf" > ``` This enables for example `objdump` to displays debug symbols. `gdb`, however, still doesn't find any symbols in the corresponding `efi` file.

I think we can close this. We have multiple tests, see https://github.com/rust-osdev/uefi-rs/blob/main/uefi-test-runner/src/proto/media/known_disk.rs#L301 feel free to re-open if I've missed something