Philipp Schuster

Results 200 comments of Philipp Schuster

I think this is what you want: ``` # ... in naersk.buildPackage { inherit src; # concat existing options with custom options # takes lambda input cargoBuildOptions = inputList: inputList...

Did anyone found a solution how angular build finds the `*.mjs` file? I have the same problem too.

Hi @hyperswine Could you please be a little bit more specific what issues you are encountering? As uefi-rs is a nostd+alloc library and uses procedural macros, IDE auto completion support...

This is independent from vscode or rust analyzer. You can execute tests with `cargo xtask test`. You can find more information here https://github.com/rust-osdev/uefi-rs/blob/main/CONTRIBUTING.md The reason for this is that this...

Thanks for putting all the work in it! That's really a great job! However, unfortunately, I'm a little concerned that this will lead to inconsistencies between the documentation from the...

I have a few nitpicks. However, I'm happy if we can merge this soon. I didn't review everything as it's quite a lot.

LGTM, feel free to merge

Hi @timrobertsdev, thanks for the PR. I wonder, didn't our [new PR template](https://github.com/rust-osdev/uefi-rs/pull/503) work for you? Or did you just delete it? I like the change, but this changes the...

oh no, this breaks our nightly MSRV https://github.com/rust-osdev/uefi-rs/actions/runs/3126569058/jobs/5072215764 How do we want to cope with that? Bumping our MSRV? @nicholasbishop I added a commit that bumps the MSRV.. if we...

Okay, I see. Intuitively, I'm against additional complexity with `cfg`-magic. > When something like that occurs we would immediately bump up the nightly MSRV and then any nice-to-have changes that...