Philipp Schuster

Results 201 comments of Philipp Schuster

> But steps 2 and 4 allocate memory which in turn might invalidate the gathered memory map. Wait. On legacy boot systems, the memory map describes which regions of the...

```rust // SAFETY: BootInformation contains a const ptr to memory that is never mutated. // Sending this pointer to other threads is sound. unsafe impl Send for BootInformation {} ```...

I'm going to postpone this a bit and merge a few other things first. The rebase needed here will have a few conflicts - I'm sorry for that!

After thinking a lot about this, I came to the conclusion that this is indeed helpful. However, I'm unsure if the proposed design is too invasive. I think, there is...

Hey. I somehow forgot about this, sorry. I'll look into it soon, hopefully. But I'm already concerned about API complexity and cognitive load

Sorry. I'm closing this due to massive internal refactorings, necessary for memory safety and removing any UB, making this unmergable. However, I think that the new design (based in `multiboot2-common`)...

I think having additional `ByresRefMut` and `TagIterMut` is fine and necessary. The duplication is fine. I'm not sure how `structDynSizedStructure` and `trait MaybeDynSized` need to be altered. Perhaps we also...

I'm sorry for the inconveniences. But all the refactorings were necessary to get rid of all UB. > but I didn't fully grasp the last one, yet. What is "the...