Philippe Auriach
Philippe Auriach
I'd accept a PR on that !
network access must be set to yes when using PHImageManager. Just made a pull request fixing this https://github.com/guillermomuntaner/GMImagePicker/pull/90
Seing this as well. To reproduce : launch GMImagePicker => deny permission => cancel => crash
That is indeed what I did, but it is not in my opinion a correct solution for your library : as GMImagePicker handles permission asking, it should also handle the...
Thank you so much, it absolutly works for me. Suggest a commit !
I did a quick tour of our libs, and KingFisher is not the only lib having iOS 10 min : - XLPagerTabStrip: 9.3 - KingFisher: 10.0 - NotificationBanner: 10.0 -...
Hi @jncosideout , thank you for your work! I tried to go through the PR but there is a lot of code :) At first sight, here are my observations:...
> Hi @philippeauriach, thank you for your critique. Allow me to respond to your comments: > > > I have the impression that you are looking to mix floatingpanel and...
Having a bit of experience with this kind of features, I suggest the following : - having some kind of "decision tree" to ask only user actively using the app,...
Yes the Storekit is pretty easy to use. I made a gist whih shows how to ask storekit only after the user compeltes a few events : https://gist.github.com/philippeauriach/311feff934205cff2f767b5e47653862 (as the...