Philip Chmielowiec

Results 263 comments of Philip Chmielowiec

> The more I think about it, I'm less sure about my suggestion of `plot` over `imshow`. > > I do still like the idea of laying groundwork to eventually...

@brianpm @kafitzgerald Actually, what about something like the following? Instead of having seperate plotting functions at this stage, what if we instead expose the sampling that we do, which can...

Exposing the sampling as opposed to writing separate functions at this point might be better, especially since we do plan to have a more direct `.plot()` accessor eventually.

Thanks for the feedback! I'll put this on draft and make some changes.

Failing tests due to a Numpy compatibility issue with Numba, see #1292

I've made the requested changes, adding a `UxDataArray.rasterize_to_geoaxes()` method. I like this design a lot more, and it directly enables more workflows than were possible with the initial implementation.

I have also updated our user guide section on [Plotting with Matplotlib and Cartopy](https://uxarray--1271.org.readthedocs.build/en/1271/user-guide/mpl.html)

Should be good for another set of reviews. I've made some reccomended changes after discussing with @erogluorhan , notably changing the signature to be `to_raster()`. Any feedback on the update...

@erogluorhan I've added a "Conversion Methods" section in the API which can house our `to_` methods and document the applications of them. https://uxarray--1271.org.readthedocs.build/en/1271/api.html#conversion-methods

Can you remove the `pc.set_transform(ccrs.PlateCarree())` line and see if that fixes things? We switched to using `ccrs.Geodetic()` as our transform, which uses Cartopy's splitting for periodic elements (hence why `periodic_elements`)...