Philip Chmielowiec comments

Results 227 comments of


                                            Philip Chmielowiec

numpy.find_common_type deprecated

@bjodah Let me know if you'd like any help. We use `pyfma` in [UXarray](https://github.com/UXARRAY/uxarray) and would like to get these changes in to support NumPy 2.0

Improve testing coverage

Will close this issue once we reach about 85-90% coverage.

Improve testing coverage

Delegation: - [ ] `uxarray.subset` @philipc2 - [x] `uxarray.remap` @aaronzedwick - [x] `uxarray.utils` @erogluorhan - [x] `uxarray.io` @rajeeja

uxgrid.to_xarray('scrip') should add units attribute

> Not sure how to attach the *.nc file. Perhaps that could be added to supported file types in the repo (within reason, so no one tries to dump a...

uxgrid.to_xarray('scrip') should add units attribute

Thanks! I can get a fix started for this, thanks for catching this!

uxgrid.to_xarray('scrip') should add units attribute

@rajeeja Was this fixed in #1282

Replace deprecated `np.find_common_type` calls with `np.promote_types`

@nschloe

Optimize `point_within_gca` by Eliminating Redundant Lat/Lon Conversions

Hi @amberchen122 This is one of the main sections we'd need to update: https://github.com/UXARRAY/uxarray/blob/82e46b8c79bb0107753398ddab096c5f6eb9b718/uxarray/grid/arcs.py#L170-L177 We should update the helper functions to take in both the Cartesian and LatLon versions of...

Optimize `point_within_gca` by Eliminating Redundant Lat/Lon Conversions

I'd like to also mention that we should try to avoid as many conversions between `np.ndarray` and `list` as possible. This could be something to considering when optimizing.

Optimize `point_within_gca` by Eliminating Redundant Lat/Lon Conversions

Closing this because of #1072