PeekPI

1. download the latest libc++ source code from llvm 2. add the following code in 'eos-vm/CMakeLists.txt' `SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -nostdinc++ -I /include")` 3. recompile eos-vm

> **Steps** > Create new contract with abi and address as params: `hmy.contracts.createContract(abi, contractAddress);` > **What expected?** > New contract instance will send to contractAddress > **What happend?** > New...

> looks good. How is this change tested? We need to at least test on localnet and testnet before launching on mainnet since it's token-related critical change. because testnet has...

test js script: ```js // fee.js const ethers = require('ethers') const provider = new ethers.providers.JsonRpcProvider('http://127.0.0.1:9500') const feeCollector = '0x19E7E376E7C213B7E7e7e46cc70A5dD086DAff2A' const faucetPrivateKey = '' const faucetWallet = new ethers.Wallet(faucetPrivateKey, provider) async...

> > Can you move the checks here to be inside `mustValid` ? > > https://github.com/harmony-one/harmony/blob/7c1c43ecbd00db4481ae0c19871c170761b6aa0c/internal/params/config.go#L706-L715 > > Secondly, can you ensure the `FeeCollectEpoch` variable is set in all `ChainConfig`...

> > @peekpi will that work for shard 1/2/3 fees ? cc @MaxMustermann2 > > Also let's assume one day we need a 5th shard, will that still work ?...

> If the `FeeCollector` is going to be a multisig, #4165 must be activated at the same time (or before) this change. This will allow movement of funds across shards...

For replay attacks, we can add `chainId` to the challenge struct or type_info struct to prevent it. I don't think use signer to prevent replay attacks is a good mechanism....

Other TODO optimization points: 1. In the current scheme, MMR can only prove block hashes. To prove a receipt, it also needs to provide the block header, then get receiptsRoot...

> > Other optimization points: > > > > 1. In the current scheme, MMR can only prove block hashes. To prove a receipt, it also needs to provide the...