Rongjian Zhang

Results 166 comments of Rongjian Zhang

Is this refactor started? If not I'd like to take it

After doing some research, I found that the usage of `termcolor` is a little different from other libraries (with just ANSI support), because [it aims to support the Windows console...

> if we can test the huge refactor accordingly Yeah, we can firstly improve the test coverage, which is currently 60% according to the badge at README, then do the...

It seems that we already have tests, but there is no check for the color. For example https://github.com/ast-grep/ast-grep/blob/d9ebbe5cc2b47876c8ef212550f34891b64bfd28/crates/cli/src/error.rs#L254-L289 I guess we can use snapshot to avoid hard code such as...

It seems caused by https://github.com/KaTeX/KaTeX/issues/2796

Sorry for the late reply. There seems to be a lot of conflict since the lastet `main` branch has significant changes. Could you please run a rebase? Then we can...

Could you please give a brief example? V3 and v4 seems not to be compatible: ```diff -"jsx": { "version": 3 }, +"jsx": { "version": 4 }, ```