Rongjian Zhang

Results 166 comments of Rongjian Zhang

![image](https://user-images.githubusercontent.com/9524411/105669362-1883a080-5f1a-11eb-9a11-426667744ef7.png) https://docs.gitlab.com/ee/api/graphql/ It is only enabled by default in the versions greater than 12.1. It should work in https://gitlab.com, but I'm not sure if our users' self-hosted GitLab matches this...

Stable channel should be fine

This is the version in my local machine: ```sh > flutter --version Flutter 2.2.1 • channel stable • [email protected]:flutter/flutter.git Framework • revision 02c026b03c (7 days ago) • 2021-05-27 12:24:44 -0700...

If the purpose is to replace `@somebody` with a link, it seems not enough to just tweak the [onTapLink](https://github.com/git-touch/git-touch/blob/master/lib/widgets/markdown_view.dart#L31) method. We should add a plugin to [flutter_markdown](https://github.com/flutter/flutter_markdown) to identify the...

> But in router.dart you've added a TODO: /github. Yeah, it is a legacy todo. We should open an issue for this: Add `/github` prefix to GitHub related screens, just...

> body.replaceAllMapped(new RegExp(r"@[^\s]+"), (match) { return "[${match[0]}](https://github.com/${match[0] })"; Oh, I missed this replacement process. This might also work but it seems more common to write a plugin for flutter_markdown

`MarkdownBody` has a property named `extensionSet`: https://pub.dev/documentation/flutter_markdown/latest/flutter_markdown/MarkdownBody-class.html For examples see: https://pub.dev/packages/markdown#syntax-extensions

There is also a legacy issue related to this: Rendering `` tag correctly. `` seems to be frequently used.

I guess this is a private repo. Is this issue reproducible in all the repos, or just this?

Thanks! There seems to be a little problem when running this branch at my local machine, visiting #168 ![Simulator Screen Shot - iPhone 12 Pro Max - 2021-02-14 at 21...