Pavan Krishna
Pavan Krishna
> 👋 I think you should open an issue to discuss the use case for this before we decide on this PR. @mx-psi the linked issue is in the PR...
@Aneurysm9 adjusted the PR per your suggestion on using feature gate. Please let me know WDYT. PR description modified accordingly.
Hi @bogdandrutu, here are our options I can keep the PR pending till we will have feature available in OTEL go SDK's autoprop module to set the propagators via configuration....
@bogdandrutu, I have updated PR per your suggestion using the new API added to `autoprop` module in `otel-go-contrib`. The API is not released yet, so I will keep the PR...
Hello @bogdandrutu @jpkrohling - The autoprop api is officially released and I have updated the PR. The PR is complete. Please review and give your blessings. :) ```yaml service: telemetry:...
> Please, revert the "retract" changes to the go.mod files. If they were intentional, please open a new PR with those isolated changes. > > Other than that, LGTM, but...
>>> As a rule of thumb in the collector we are moving away from env variables in general (allow them only as part of the yaml config via embedding). So...
Updated the PR per @bogdandrutu suggestion, the configuration is a list now ```yaml receivers: otlp: protocols: grpc: exporters: otlphttp: endpoint: http://0.0.0.0:3000 traces_endpoint: http://0.0.0.0:3000/v1/trace tls: insecure: true logging: processors: batch: service:...
@bogdandrutu - just summarizing the suggestions from you, to make sure I didn;t miss any 1. Limiting the propagators that we allow (tracecontext, b3) - this can be done if...
Thanks @bogdandrutu - updated the PR per your suggestions. Kindly review