Old Dip Tracker

Results 573 comments of Old Dip Tracker

I cherry-picked the unit test from 41b88e933, this is now ready for review. I'm aware that there are multiple renames back and forth on this code that can influence picks;...

> asyncore depreciation Yes, we'll have to fix that separately - not related to this code. Would you mind filing an issue with a log?

Concept ACK, but implementation NAK because this iterates over the entire chain on an RPC call, which is even more expensive than our current `gettxoutsetinfo`. Have a look at [Bitcoin's...

The 40% failure rate wasn't a joke - I'm manually restarting nearly half the CI runs. Line 175 is the other place where we're testing notifications post-reorg, just like line...

Thank you. > without explicitly enabling `scrypt-sse2` support This PR does not change the experimental-ness of `scrypt-sse2` and you should still pass `--enable-experimental --enable-scrypt-sse2` > For this PR I've got...

I reviewed the logs... your result is a 2x worse performance when compiling without SSE2 enabled. I will try to reproduce these results, because that would be an unintended effect.

@victorsk2019 2 notes: 1. Using `--enable-debug` may not be optimal when doing benchmarks, as that compiles with `-O0` (and your make log must be full of warnings if you do...

The reason on-push doesn't work for changing files is caused by rebase, because rebase changes history. I played with the thought for a moment to write a custom diff script...

Could you please share your config.log?