pali

Results 504 comments of pali

This common code is for modifying existing udf fs, so it should not be in udfinfo dir. udflabel dir is for label related stuff. So put it into new udftune...

I was waiting until you finish it. There are still lot of duplicated copy+paste code in udftune/main.c file. For example code for checking access type or code which do descriptors...

You already figured out that it is that non-fsd/lvd code.

> Apart from that, is there any improvement you need made before this can get merged? Yes, I have already [wrote](https://github.com/pali/udftools/pull/63#issuecomment-1548216979) that there is duplicated code for checking access type....

I will look at the changes carefully later. But it looks better now. And about CI, just ignore it, I will take care about Travis CI issues.

Hello, sorry for a longer delay. I was looking at it. It looks better, I have few comments below and ignore CI issue for now. * Rename `sync_device` to something...

And also there is missing udftune documentation - manual page - in similar form as there is existing one for udflabel (explanation of all command line options; plus description what...

Now I see that you pushed updated to this PR (github did not sent me notification). Could you squash relevant changes together and do force-push? Because for example now there...

@zocker007 Could you address above comments for this PR?

> why don't merge the changes about igmpv3 Because there is no change ready. See review comments above.