igmpproxy
igmpproxy copied to clipboard
pali
Implement sending of IGMPv3 query
According to RFC 2236, IGMPv2/v1 clients should ignore additional fields in query, but build the checksum over the whole IP-Packet. So this is designed for future compatibility and it should be by design to send IGMPv3 queries, when a v3 capable router is in the network.
Hello! Could you describe why is this change needed? Is it fixing some bug or are there any issues with current implementation?
This PR is a preparation for following commits regarding IGMPv3 source specific multicast. The first step here is to implement sending of IGMPv3 queries.
Ok. Now I see the reason.
Anyway, I'm not sure if it is safe to "upgrade" all packets unconditionally. RFC documents are strict how client should behave but because I know there are tons of broken software it is not really a good idea to upgrade code to always use IGMPv3 packets only.
What do you think about it?
Would not it be better to add e.g. config option for specifying which IGMP protocol version should be used on particular interface?
Yes, thats a good point. I think an config option would be good. I will show how to add a config flag and use it.
Ok, please look at this how hard is to add config option and if you can do it during your IGMPv3 support on downstream interfaces.
Hi, does this mean that IGMPv3 will now be supported (new version released soon)?
@horolux I'm not sure if this PR is going anywhere atm, but it looks like there might be two versions of igmpproxy with IGMPv3 support: https://github.com/zocker007/igmpproxy from @zocker007 https://github.com/Uglymotha/igmpv3proxy from @Uglymotha
I'm guessing you'll have to build the versions manually.
I have yet to try their versions, but I'm hoping I'll get to it in the future (both forks also don't have Issue trackers open right now). I very much appreciate the work of both (and pali too of course!)
Edit: It also seems like the original igmpproxy includes some sort of "IGMPv3 client support" since v0.2. Edit 2: Feels a bit weird to ask here, but in case you're seeing this Uglymotha/zocker007, are there pre-built (debian) (arm64) packages for your custom igmpproxy versions?
I'm planning to look and review this change properly. Just need to find some free time for it.
@pali Hey, when can I use the new version of the igmpproxy? I need the IGMPv3 support for the german IPTV
Best regards itobi1
@horolux I'm not sure if this PR is going anywhere atm, but it looks like there might be two versions of igmpproxy with IGMPv3 support: https://github.com/zocker007/igmpproxy from @zocker007 https://github.com/Uglymotha/igmpv3proxy from @Uglymotha
I'm guessing you'll have to build the versions manually.
I have yet to try their versions, but I'm hoping I'll get to it in the future (both forks also don't have Issue trackers open right now). I very much appreciate the work of both (and pali too of course!)
Edit: It also seems like the original igmpproxy includes some sort of "IGMPv3 client support" since v0.2. Edit 2: Feels a bit weird to ask here, but in case you're seeing this Uglymotha/zocker007, are there pre-built (debian) (arm64) packages for your custom igmpproxy versions?
@TheJulianJES Hey, did you test the versions from zocker007 or Uglymotha? Do you also need it for your IPTV?
@pali Hi，why don't merge the changes about igmpv3 query in version 0.4? I still don't know how to enable the igmpv3...
why don't merge the changes about igmpv3
Because there is no change ready. See review comments above.
@pali could you please look at this PR and merge as @zocker007 has made the changes since last time ? look forward to using igmpv3
