Paul Smith

Results 44 comments of Paul Smith

Yeah that's a good point, changing the topology necessarily means you end up with a new mesh. But it would be nice to be able to use smooth shading without...

> Nice work on this one. Agree with changes. Thanks for the fast review!

Hi, I'm not sure why building the docs failed (the error message is [not very helpful](https://github.com/pyvista/pyvista/runs/7542113956?check_suite_focus=true#step:14:9802)), but building the docs in [this other pr](https://github.com/pyvista/pyvista/pull/3031#issue-1309901687) seems to fail for no reason...

Ah, well spotted! Looks like there was a discussion raised about this recently: https://github.com/pyvista/pyvista/discussions/2747#discussion-4121408

Thanks for looking into it! I'll convert this to a draft for now then

Thank you for drafting this so quickly @tkoyama010! It works locally with python=3.9 and vtk=9.1

Yep you're right - for some reason I assumed the edge length was not taken into account, and only the number of edges was considered. But this is not the...

Sorry, it's for the one that's already the behaviour

Hi, sorry for the really slow reply. > We should add some logic to handle this automatically That's a fair point. I think the most common way to handle this...

That might not be quite what you're after though. Another option would be to do something similar to what matplotlib does. Matplotlib have created `matplotlib-base` and `matplotlib`. `matplotlib-base` is the...