Ozan Gunalp

Results 232 comments of Ozan Gunalp

I don't have the permission to push to your PR: the code is here https://github.com/smallrye/smallrye-reactive-messaging/commits/cdennison/main. Please feel free to review it and integrate into your PR.

I wonder if smallrye config provides an interceptor for stripping `"` from values.

Isn't this the case for every config property? For exemple if you pass `value.serializer="org.apache.kafka.common.serialization.StringSerializer"` config you'd get a ClassNotFoundException.

@kdubb I am sorry, your comment went totally under my radar. IIRC it is not currently possible to use map as a connector attribute. It is possible to extract free-form...

@kdubb for `MessageConverter` failure handling

@kdubb I understand that the documentation doesn't say that the canConvert function is called once on lookup. But I don't think that the current implementation is wrong per se. When...

I understand that the penalty is negligible. I think `MessageConverter` was designed to adapt the message to the injection point type, rather than to parse the payload. If you don't...

Closing this in favour of #1896

This looks good to me. @kabir do you have anything else to do? @cescoffier now that we have vert.x 4.3.4 in dependency this is good to go, wdyt ?

@Nidum thanks for reporting this! I tried to answer this issue in https://github.com/smallrye/smallrye-reactive-messaging/discussions/1852#discussioncomment-3466705