smallrye-reactive-messaging icon indicating copy to clipboard operation
smallrye-reactive-messaging copied to clipboard

Add rabbitmq quickstart

Open cdennison opened this issue 3 years ago • 4 comments

Implements #1696

cdennison avatar Apr 07 '22 15:04 cdennison

@cdennison Thanks for your PR. I think you need to add merge=true to the to-rabbitmq-string channel for the Emitter to channel to work.

ozangunalp avatar Apr 08 '22 07:04 ozangunalp

@cdennison Thanks for your PR. I think you need to add merge=true to the to-rabbitmq-string channel for the Emitter to channel to work.

Yes that was the issue - I don't want to introduce merged streams in the quickstart so I just changed the channel name. My updated PR now has a working emitter example.

As a side note if would nice if there was a more helpful error than the following when merge is required: [WARNING] org.jboss.weld.exceptions.DeploymentException: Wiring error(s) detected in application.

cdennison avatar Apr 08 '22 13:04 cdennison

The detailled error is in the suppressed exceptions. You need to configure the logger to display them.

On Fri 8 Apr 2022 at 15:49, Charlie Dennison @.***> wrote:

@cdennison https://github.com/cdennison Thanks for your PR. I think you need to add merge=true to the to-rabbitmq-string channel for the Emitter to channel to work.

Yes that was the issue - I don't want to introduce merged streams in the quickstart so I just changed the channel name. My updated PR now has a working emitter example.

As a side note if would nice if there was a more helpful error than the following when merge is required: [WARNING] org.jboss.weld.exceptions.DeploymentException: Wiring error(s) detected in application.

— Reply to this email directly, view it on GitHub https://github.com/smallrye/smallrye-reactive-messaging/pull/1697#issuecomment-1092879835, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADCG7NL2FND5X2J4NPGB7TVEA2NVANCNFSM5SZYFQXQ . You are receiving this because you are subscribed to this thread.Message ID: @.*** com>

cescoffier avatar Apr 08 '22 14:04 cescoffier

Codecov Report

Merging #1697 (f485e5a) into main (2ae4e8b) will decrease coverage by 61.10%. The diff coverage is n/a.

:exclamation: Current head f485e5a differs from pull request most recent head 1272f5c. Consider uploading reports for the commit 1272f5c to get more accurate results

Impacted file tree graph

@@              Coverage Diff              @@
##               main    #1697       +/-   ##
=============================================
- Coverage     73.84%   12.73%   -61.11%     
+ Complexity     3064      439     -2625     
=============================================
  Files           268      268               
  Lines         11000    11000               
  Branches       1414     1414               
=============================================
- Hits           8123     1401     -6722     
- Misses         2197     9410     +7213     
+ Partials        680      189      -491     
Impacted Files Coverage Δ
...allrye/reactive/messaging/health/HealthReport.java 0.00% <0.00%> (-100.00%) :arrow_down:
...ipse/microprofile/reactive/messaging/Metadata.java 0.00% <0.00%> (-100.00%) :arrow_down:
...tive/messaging/ce/impl/BaseCloudEventMetadata.java 0.00% <0.00%> (-100.00%) :arrow_down:
...messaging/ce/DefaultCloudEventMetadataBuilder.java 0.00% <0.00%> (-100.00%) :arrow_down:
...ssaging/tck/SmallRyeReactiveMessagingExtender.java 0.00% <0.00%> (-100.00%) :arrow_down:
...ing/ce/impl/DefaultIncomingCloudEventMetadata.java 0.00% <0.00%> (-100.00%) :arrow_down:
...ing/ce/impl/DefaultOutgoingCloudEventMetadata.java 0.00% <0.00%> (-100.00%) :arrow_down:
...smallrye/reactive/messaging/jms/JmsProperties.java 0.00% <0.00%> (-100.00%) :arrow_down:
...smallrye/reactive/messaging/mqtt/MqttFailStop.java 0.00% <0.00%> (-100.00%) :arrow_down:
...allrye/reactive/messaging/jms/i18n/JmsLogging.java 0.00% <0.00%> (-100.00%) :arrow_down:
... and 207 more

codecov-commenter avatar Apr 12 '22 08:04 codecov-commenter

@ozangunalp or @cescoffier are you waiting on me to do anything to merge this PR? Thanks

cdennison avatar Aug 29 '22 17:08 cdennison

@cdennison the quickstart code seems correct. I had an issue with the rabbbitmq image you used: the connections were established but no message transmission was taking place. I think there was an authorization issue.

I changed the container to the default rabbitmq image and added the example project to reactor.

ozangunalp avatar Aug 30 '22 08:08 ozangunalp

I don't have the permission to push to your PR: the code is here https://github.com/smallrye/smallrye-reactive-messaging/commits/cdennison/main. Please feel free to review it and integrate into your PR.

ozangunalp avatar Aug 30 '22 08:08 ozangunalp

@ozangunalp looks good to me - I merged your branch into mine.

cdennison avatar Sep 02 '22 16:09 cdennison