Chris Renshaw

About the SELinux thing.. https://github.com/topjohnwu/Magisk/issues/1477 And https://github.com/topjohnwu/Magisk/commit/bc6a14d30f74a217e6c88835e5cbf452a3d7255b I forget the why of it now, but John intentionally switched from setting the prop to 0 (the correct value apparently, per above)...

> I saw this, but don't understand why. I can't find any documents about this prop. But some Q&A told me that when SELinux Enforcing, this prop should be 1....

Some of those SELinux bind mounts and chmods might interfere with integral new Magisk stuff: https://github.com/topjohnwu/Magisk/commit/2fb49ad7806bbe50ac60ea223cba93e6cb54a226 References: https://github.com/topjohnwu/Magisk/commit/49f259065d5d2a1d748ddb5c1e38afd365eaa1c1 https://github.com/topjohnwu/Magisk/commit/e841aab9e73cb4ec4b9419c13b27d12b1599cbb3 https://github.com/topjohnwu/Magisk/commit/753808a4ce524f6979dc580fa00dc9baafee620c

Live policy patching causes kernel panic on several vendors. Also, no. We should not nuke SELinux. 🙃

Also perhaps not advisable anymore: https://github.com/kdrag0n/safetynet-fix/pull/166#issuecomment-1073115540 But, having read into it more now, perhaps could work since all the Magisk sepolicy hijacking stuff is pre-init.. 🤔

Basically this would have to be adapted to Zygisk: https://github.com/redlee90/Hide-USB-Debugging-Mode

How does the custom TWRP write itself into the kernel, though? And why doesn't it persist after Magisk Direct install? That would be the thing to fix here, not disabling...

Ah, I knew this rang a bell: https://github.com/topjohnwu/Magisk/pull/2840#issuecomment-636204251

Relevant bits from my research and implementation for AIK amonet support: Detection: https://github.com/osm0sis/Android-Image-Kitchen/commit/94e33e000c611127fd522b5245ab23dcbeae080e#diff-eaa2c4e5d6677c9e84e95b4342f94ab6788625d30ac34f0987979d54457db96dR35-R36 Unpacking: https://github.com/osm0sis/Android-Image-Kitchen/commit/94e33e000c611127fd522b5245ab23dcbeae080e#diff-8cab25a87eb22e45b3d01b96b9cf1d9e65f6e61f250e6344a1d7d393987ec86dR135-R145 Repacking: https://github.com/osm0sis/Android-Image-Kitchen/commit/94e33e000c611127fd522b5245ab23dcbeae080e#diff-2806377b37f5f32702c6d2fc69d6937a6e32197359cc140b1fd1b14b3d6c2de7R312-R319 It's beyond me to add it to magiskboot though, but perhaps @chaosmaster (k4y0z...

We added Nook bootloader hack support way back, for example: https://github.com/topjohnwu/Magisk/commit/28350e3ad92dc8f11d05ec79f4f863caa4ce0c61 https://github.com/topjohnwu/Magisk/commit/d780b5a0e4107c81beb6e5df7f5f0dff54681daa https://github.com/topjohnwu/Magisk/commit/2ff5d9606b575726bd30d89c6d029e30f33a90a3 There are a lot more developers now too, so things may happen more quickly, but either way...