java-spring-web

java-spring-web copied to clipboard

Please take a look at https://github.com/winster/jaeger-trace-reactive This is a spring boot application with opentracing. As per the doc, java-spring-cloud supports webflux and webclient. But the trace is finished before the...

winster

`TracingHandlerInterceptor` is created in that way there is no possibility of changing order of that interceptor like it's done for `TracingFilter`. (both beans are configured in `ServerTracingAutoConfiguration`) IMO it should...

kohegen

version tested on: 0.4.0 spans are not marked with `error=true` when the exceptions are caught using a `ControllerAdvice`. Using ControllerAdvice is very common and this causes a lot of errors...

piyushmor

1. TracingHandlerInterceptor puts a handler object into log fields. See [this](https://github.com/opentracing-contrib/java-spring-web/blob/master/opentracing-spring-web/src/main/java/io/opentracing/contrib/spring/web/interceptor/HandlerInterceptorSpanDecorator.java#L77). 2. ZipkinV2Reporter converts log fields to JSON via Gson to build JaegerSpan annotations. See [this](https://github.com/jaegertracing/jaeger-client-java/blob/master/jaeger-zipkin/src/main/java/io/jaegertracing/zipkin/internal/V2SpanConverter.java#L87). 3. Gson inspects private...

eungju

For async requests, thread-bound resources should be cleaned in method `afterConcurrentHandlingStarted` of `TracingHandlerInterceptor` interceptor as is suggested in the document [AsyncHandlerInterceptor](https://docs.spring.io/spring-framework/docs/current/javadoc-api/org/springframework/web/servlet/AsyncHandlerInterceptor.html). https://github.com/opentracing-contrib/java-spring-web/blob/5262c01c5223ff2931685b9b572ce869b0c5caa8/opentracing-spring-web/src/main/java/io/opentracing/contrib/spring/web/interceptor/TracingHandlerInterceptor.java#L117 In this case, I suppose active scope should...

lujiajing1126

Why is TracingHandlerInterceptor conditional on missing TracingFilter?

3

Code in question: https://github.com/opentracing-contrib/java-spring-web/blob/8b802bafbc2ae81cb4677e0a9273a2f6a54519ea/opentracing-spring-web-starter/src/main/java/io/opentracing/contrib/spring/web/starter/ServerTracingAutoConfiguration.java#L100-L102 The source code of `TracingHandlerInterceptor` seems to suggest that it's meant to be used in conjunction with the `TracingFilter`: https://github.com/opentracing-contrib/java-spring-web/blob/696627213665174f3df5e4dbad405045066d54d0/opentracing-spring-web/src/main/java/io/opentracing/contrib/spring/web/interceptor/TracingHandlerInterceptor.java#L90

whiskeysierra

TracingFilter and ServletFilterSpanDecorator

5

Hi, in this line https://github.com/opentracing-contrib/java-spring-web/blob/master/opentracing-spring-web-starter/src/main/java/io/opentracing/contrib/spring/web/starter/ServerTracingAutoConfiguration.java#L87 the lib is checking for some `ServletFilterSpanDecorator` decorators. Yesterday I had to create a custom decorator for me and I noticed that if I register...

williamokano

Run tests on Netty for WebFlux

10

WebFlux doesn't require jetty or tomcat. It uses netty. Is it possible to get rid of jetty from WebFlux integration tests?

malafeev

add uber-trace-id for request header

6

so microservice can get this for inherit span

aslongyouloveme

Spans are not connected after upgrading spring-web-starter

3

Dear Community, Different services spans can not be connected after upgrade below old version ``` opentracing-spring-jaeger-starter:0.1.4 opentracing-spring-web-starter:0.3.3 ``` to new version ``` opentracing-spring-jaeger-starter:2.0.0 opentracing-spring-web-starter:2.1.0 ``` Before the upgrading, everything is...

lubinson