Why is TracingHandlerInterceptor conditional on missing TracingFilter?

[whiskeysierra]

Code in question:

https://github.com/opentracing-contrib/java-spring-web/blob/8b802bafbc2ae81cb4677e0a9273a2f6a54519ea/opentracing-spring-web-starter/src/main/java/io/opentracing/contrib/spring/web/starter/ServerTracingAutoConfiguration.java#L100-L102

The source code of TracingHandlerInterceptor seems to suggest that it's meant to be used in conjunction with the TracingFilter:

https://github.com/opentracing-contrib/java-spring-web/blob/696627213665174f3df5e4dbad405045066d54d0/opentracing-spring-web/src/main/java/io/opentracing/contrib/spring/web/interceptor/TracingHandlerInterceptor.java#L90

[geoand]

@pavolloffay do you remember? I think you added that piece of code.

[pavolloffay]

Based on git blame https://github.com/opentracing-contrib/java-spring-web/pull/39

[whiskeysierra]

That pull request doesn't really explain why though.

On Fri, 29 Nov 2019, 18:20 Pavol Loffay, [email protected] wrote:

Based on git blame #39 https://github.com/opentracing-contrib/java-spring-web/pull/39

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/opentracing-contrib/java-spring-web/issues/120?email_source=notifications&email_token=AADI7HNHFLLROQHDNQUJ36TQWFFPDA5CNFSM4JSHVW3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFPJ7MA#issuecomment-559849392, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADI7HPFJRSRKCGMXZS26BLQWFFPDANCNFSM4JSHVW3A .