Jacob Thomason

Results 203 comments of Jacob Thomason
trafficstars

> Let's update this PR such that the docs direct the reader to the examples, instead of maintaining any code here. @shish ^^

@shish would be nice to get this merged. If you're giving up, I'll have to close it.

@sebastianbergmann that's a good point. Overall, paratest would be a more accurate place to handle this, since it can accurately distribute amongst the runners. Here is a comment on the...

@mgol these are unit tests. Can you please explain what about this change needs to be added or updated with unit tests? As for integration tests, which is actually the...

@mgol How are you going to write a unit test for something that's dynamically calculated based on a browser window's scroll position?

Okay, I've added a test for the positioning with the more lazily calculated top position. The issue occurs in more complex positioning scenarios. I've added a test that creates a...

@mgol thanks for the feedback on this. The reality here is that I am not familiar with qunit, or this lib's unique testing setup that comes with lots of pre-build...

@shish I think this is a reasonable solution. However, it's not going to remain accurate unless there are tests for it. We should probably update the `.github/workflows/continuous_integration.yml` to include a...

Converted this to a draft until the TODO items are completed.

> For reasons I am struggling to figure out, this runs fine on my dev machine but fails in github T_T > > ``` > cd examples/no-framework > composer install...