Jacob Thomason

Results 201 comments of Jacob Thomason
trafficstars

@vyaaki be great if you could submit a PR with tests.

@bladl why not continue to support PHP 8.0? We can still support Symfony 6.1 components with PHP 8.0 support as well. It just means if your target PHP version is...

@bladl Enums are already implemented and don't require that we drop 8.0 support. Readonly properties and intersection types are cool, but I don't see any need to implement them requiring...

It'd be great to get a PR put together to begin cleaning up for the 8.0 min support if someone wants to take the initiative.

This would be a minor update, yes - 5.1 for instance.

> I tell about internal use of enums. For example replacing constants below with enums: I agree it'd be nice to replace constants with Enums. However, it doesn't change functionality...

Yes, 6.1 - sorry. The CHANGELOG looks like it didn't get updated on the last release. Honestly, that file is mostly a duplicate of the release notes. I'm wondering if...

We definitely can. It would obviously be a BC break. I’m, personally, in favor of doing so and removing Doctrine annotation dependencies. It’ll probably require many people to refactor that...

Excellent. I probably added that, actually. We can just reference that in the release notes.

> Can I replace `Webmozart\Assert\Assert` with native `assert()` for performance and better IDE code suggestion reason? Does that Assert lib throw exceptions in a non dev env? If the result...