onbjerg

Results 430 comments of onbjerg

Tradeoff is that it's easier to figure out what environment variables to set if you use `[rpc_endpoints]` since it's all in the config vs having to read through all of...

Closing, should be fixed in the latest nightly, reopen if it's still an issue with some additional context :smile:

I think there was talk of source maps being added to the Etherscan API (it's already present in the UI) - is this something we can get confirmed somewhere, and...

> it's not yet included in the `getsourcecode` api `https://api.etherscan.io/api?module=contract&action=getsourcecode` Yeah, I meant that there was talks that it would be included soon-ish. I just don't know when, but if...

Alright, I was just saying that if it would be added soon there probably wouldn't be much of a point adding something we are going to delete, but if you...

I think `[SKIP]` is better (works w/ pass and fail) Edit: Also to keep in line with current naming conventions `testSkip` would probably also be the most appropriate :smile:

No it's only the start of the test function: `testSkip*`. However you bring up a good point separately: it would make something like `testFail` not skippable :( Not sure

Note on implementation: This could be a cheatcode (`vm.skip(bool)`) that simply reverts with some magic bytes. When a test reverts, we then check if the revert is the magic bytes,...

I wonder if this is needed anymore since we now have fork-related cheatcodes to choose what fork to use on a per-test level? Wdyt @vminkov? I can't really think of...