Oli Scherer

icon company @aws icon location Phobos

Results 745 comments of Oli Scherer

Require `#[const_trait]` on `Trait` for `impl const Trait`

> `let x = Default::default;` shouldn't require the `Self` type to be const, right? Unless we are talking about const fn pointers hmm good point, until we have those we...

Avoid duplicating StorageLive in let-else

Please also add a mir-opt test. https://github.com/rust-lang/rust/pull/101410#issuecomment-1248806073 seems like a good candidate as it is very minimal.

Avoid duplicating StorageLive in let-else

@bors r+ p=1 (unblocks miri)

Move lint level source explanation to the bottom

@bors delegate+ Feel free to move this PR along yourself

Move lint level source explanation to the bottom

@bors r=estebank

MirPhase: clarify that linting is not a semantic change

@bors r+ rollup

Improve error for when query is unsupported by crate

Thanks! I think this'll be helpful for anyone encountering the situation @bors r+ rollup

Optimize `array::IntoIter`

@bors retry (cycling a higher priority PR) https://github.com/rust-lang/rust/pull/102028

#95295 causes unsoundness in multiple existing crates

cc @rust-lang/libs-api

Make typeck aware of uninhabited types

@bors try let's do a crater run