Oli Scherer

Results 745 comments of Oli Scherer

sorry, this issue must've gotten lost in my emails... That's a great Idea, I'll address it.

Doing files is hard... You usually want to continue reading in the file with a new `read!` call or similar... so right now it looks like ``` rust use std::io::Read;...

> it's just the text file we could put that in the perf S3 bucket (alongside the self profile data), but that would mean that querying many commits at the...

> But if you're mostly thinking that we'll be diffing two, then it should be easy to just store them in the S3 bucket; two get requests are relatively cheap....

@rustbot cancel (see zulip thread)

I'm not sure if these should be in the Cargo.toml, as we many want to be able to specify them globally for a group of projects.